Skip to content

docs(ja): use English operator names in choose-index.md#23048

Merged
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-operator-names
Jun 16, 2026
Merged

docs(ja): use English operator names in choose-index.md#23048
qiancai merged 2 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-operator-names

Conversation

@yahonda

@yahonda yahonda commented Jun 12, 2026

Copy link
Copy Markdown
Member

Replaced Japanese katakana operator names with their original English names since these are proper operator names in TiDB:

Before After
テーブルリーダー TableReader
インデックスリーダー IndexReader
インデックスマージ IndexMerge

Also fixed: 列ベースのstorage → 列ベースのストレージ

Link texts and descriptions remain in Japanese.

TableReader, IndexReader, and IndexMerge are operator names and should
remain in English even in Japanese documentation.
@ti-chi-bot

ti-chi-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jackysp for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the choose-index.md Japanese documentation by replacing translated operator names (such as "テーブルリーダー", "インデックスリーダー", and "インデックスマージ") with their English equivalents ("TableReader", "IndexReader", and "IndexMerge") to maintain consistent terminology. The reviewer pointed out that one of the markdown links was changed to English ([Explain Statements Using Index Merge]), which contradicts the PR description stating that link texts should remain in Japanese. A suggestion was provided to keep the link text in Japanese as [インデックスマージを使用したステートメントの説明].

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread choose-index.md Outdated
@yahonda yahonda force-pushed the fix-operator-names branch from 988de9e to 48babc5 Compare June 16, 2026 01:58
@ti-chi-bot ti-chi-bot Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 16, 2026
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jun 16, 2026
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 16, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-06-16 03:12:26.01413613 +0000 UTC m=+1448047.084453510: ☑️ agreed by qiancai.

@qiancai qiancai merged commit 440e835 into pingcap:i18n-ja-release-8.5 Jun 16, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants